New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more words #12852

Merged
merged 3 commits into from May 8, 2018

Conversation

Projects
None yet
4 participants
@ckerr
Member

ckerr commented May 7, 2018

Inspired by @codebytere's PR and by this article (which appears to have inspired the tweet 馃槃)

This PR removes the words 'basically' and 'simply' from the docs. It also removes many uses of 'just' depending on context: it's kept in phrases like ''just before' or 'just after', but removed from phrases like 'to do X, just build Y'.

@ckerr ckerr requested a review from electron/docs as a code owner May 7, 2018

@codebytere

馃挒

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound May 8, 2018

Member

@ckerr I don't suppose you made a cool grep command to find these 馃 Would love to do this on my other projects 馃憤

Member

MarshallOfSound commented May 8, 2018

@ckerr I don't suppose you made a cool grep command to find these 馃 Would love to do this on my other projects 馃憤

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr May 8, 2018

Member

@MarshallOfSound to find these? Not sure I understand the question -- cd docs; git grep -i simply will find them.

Member

ckerr commented May 8, 2018

@MarshallOfSound to find these? Not sure I understand the question -- cd docs; git grep -i simply will find them.

@ckerr ckerr merged commit 4d078fd into master May 8, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the remove-more-words branch May 8, 2018

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke May 24, 2018

Member

Finally found the thing I was trying to remember: http://alexjs.com

Member

zeke commented May 24, 2018

Finally found the thing I was trying to remember: http://alexjs.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment