New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Windows specific DIP <-> screen coordinate conversion methods #12879

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
4 participants
@miniak
Contributor

miniak commented May 10, 2018

These methods are mapped to the following APIs in display::win::ScreenWin (libchromiumcontent/src/ui/display/win/screen_win.h):

  • ScreenToDIPPoint
  • DIPToScreenPoint
  • ScreenToDIPRect
  • DIPToScreenRect

This new API is useful when calling Windows APIs in native code (node modules), which operate on physical coordinates.

@miniak miniak requested review from electron/docs as code owners May 10, 2018

@miniak miniak changed the title from Expose screenToDipRect / dipToScreenRect methods to Expose Windows specific DIP <-> screen coordinate conversion methods May 10, 2018

@miniak miniak requested review from juturu, alespergl and zcbenz May 10, 2018

Show outdated Hide outdated docs/api/screen.md
@zcbenz

zcbenz approved these changes May 16, 2018

👍

@zcbenz zcbenz merged commit 211d782 into master May 16, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zcbenz zcbenz deleted the screen-api branch May 16, 2018

@tong

This comment has been minimized.

Show comment
Hide comment
@tong

tong Jul 21, 2018

tong/hxelectron#35 … wondering if this is ok.
Seems to be the one and only place where this main/renderer process incompatibility happens.

tong commented Jul 21, 2018

tong/hxelectron#35 … wondering if this is ok.
Seems to be the one and only place where this main/renderer process incompatibility happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment