New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't declare IsDesktopEnvironmentUnity on non-Linux #12885

Merged
merged 1 commit into from May 10, 2018

Conversation

Projects
None yet
2 participants
@nornagon
Contributor

nornagon commented May 10, 2018

It's only called from linux, and was causing an unused function error with the GN build.

@nornagon nornagon requested a review from electron/reviewers as a code owner May 10, 2018

@nornagon nornagon referenced this pull request May 10, 2018

Merged

GN build #12837

@nornagon nornagon merged commit 9aa18d2 into electron:master May 10, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nornagon nornagon deleted the nornagon:is-desktop-unity branch May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment