New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow frameless transparent windows to be sized smaller than 64x64 on Windows #12904

Merged
merged 4 commits into from May 14, 2018

Conversation

Projects
None yet
3 participants
@brenca
Member

brenca commented May 12, 2018

Fixes #12875

There is a workaround in chromium for an AMD graphics driver issue that causes windows to be always expanded to be at least 64x64 pixels in size. This works flawlessly in chromium, but we are using SizeConstraints when the window is set to resizable: false, which messes with this behavior.

I've added code to allow the MaximumSize to be expanded as well when the workaround internally applies.

@brenca brenca requested a review from electron/reviewers as a code owner May 12, 2018

brenca added some commits May 12, 2018

@jkleinsc jkleinsc merged commit 0fd8513 into master May 14, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the fix-12875 branch May 14, 2018

@jkleinsc jkleinsc restored the fix-12875 branch May 14, 2018

@jkleinsc

This comment has been minimized.

Show comment
Hide comment
@jkleinsc

jkleinsc May 14, 2018

Contributor

/trop run backport-to 1-8-x

Contributor

jkleinsc commented May 14, 2018

/trop run backport-to 1-8-x

@jkleinsc

This comment has been minimized.

Show comment
Hide comment
@jkleinsc

jkleinsc May 14, 2018

Contributor

/trop run backport-to 2-0-x

Contributor

jkleinsc commented May 14, 2018

/trop run backport-to 2-0-x

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 14, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "1-8-x" here we go! :D

trop bot commented May 14, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "1-8-x" here we go! :D

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 14, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

trop bot commented May 14, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 14, 2018

An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually

trop bot commented May 14, 2018

An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 14, 2018

An error occurred while attempting to backport this PR to "2-0-x", you will need to perform this backport manually

trop bot commented May 14, 2018

An error occurred while attempting to backport this PR to "2-0-x", you will need to perform this backport manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment