New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions #12912

Merged
merged 1 commit into from May 14, 2018

Conversation

Projects
None yet
3 participants
@chicoxyzzy
Contributor

chicoxyzzy commented May 14, 2018

Update installation instructions for Electron 2

@chicoxyzzy chicoxyzzy requested a review from electron/reviewers as a code owner May 14, 2018

@zeke

zeke approved these changes May 14, 2018

Good catch. Thanks!

@jkleinsc jkleinsc merged commit 14f4108 into electron:master May 14, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@chicoxyzzy chicoxyzzy deleted the chicoxyzzy:patch-1 branch May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment