New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow frameless transparent windows to be sized smaller than 64x64 on Windows #12923

Merged
merged 2 commits into from May 16, 2018

Conversation

Projects
None yet
3 participants
@brenca
Member

brenca commented May 14, 2018

Backport of #12904

Trop should be able to backport thisto 1-8-x now.

@brenca brenca requested a review from jkleinsc May 14, 2018

@brenca brenca requested a review from electron/reviewers as a code owner May 14, 2018

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound May 14, 2018

Member

@brenca Some test failures here in this backport 😢 Seem to be a result of a version bump in electron-typescript-definitions. If you lock electron-typescript-definitions to exactly 1.3.2 then it will pass 👍

Member

MarshallOfSound commented May 14, 2018

@brenca Some test failures here in this backport 😢 Seem to be a result of a version bump in electron-typescript-definitions. If you lock electron-typescript-definitions to exactly 1.3.2 then it will pass 👍

@brenca

This comment has been minimized.

Show comment
Hide comment
@brenca

brenca May 15, 2018

Member

@MarshallOfSound I did that, the current failure seems unrelated, but I'm not sure.

Member

brenca commented May 15, 2018

@MarshallOfSound I did that, the current failure seems unrelated, but I'm not sure.

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound May 15, 2018

Member

@brenca I kicked the builds into a re-run

Member

MarshallOfSound commented May 15, 2018

@brenca I kicked the builds into a re-run

@jkleinsc

LGTM

@jkleinsc jkleinsc removed the target/2-0-x label May 16, 2018

@jkleinsc jkleinsc merged commit 9796513 into 2-0-x May 16, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 16, 2018

An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually

trop bot commented May 16, 2018

An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually

@jkleinsc jkleinsc deleted the fix-12875-2-0-x branch May 16, 2018

@brenca

This comment has been minimized.

Show comment
Hide comment
@brenca

brenca May 17, 2018

Member

Trop, y u do dis :( I'm gonna backport this to 1-8-x in the upcoming days.

Member

brenca commented May 17, 2018

Trop, y u do dis :( I'm gonna backport this to 1-8-x in the upcoming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment