New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript generation error #12940

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
2 participants
@jkleinsc
Contributor

jkleinsc commented May 15, 2018

We need to lock down electron-typescript-definitions because it was pulling in a newer version incompatible with 2-0-x

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner May 15, 2018

@ckerr

ckerr approved these changes May 15, 2018

LGTM for the short term.

We ought to consider syncing the release numbers withelectron-typescript-definitions to make this more intuitive, but that's probably an issue to be opened in the e-t-d tracker

@ckerr ckerr merged commit 0070637 into 2-0-x May 15, 2018

10 of 11 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the fix-ts-2-0-x branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment