New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gn] Include node/common.gypi when building node #12948

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
2 participants
@nornagon
Contributor

nornagon commented May 15, 2018

Not sure how this ever worked, but the GN build certainly doesn't work
on Linux without this.

[gn] Include node/common.gypi when building node
Not sure how this ever worked, but the GN build certainly doesn't work
on Linux without this.

@nornagon nornagon requested a review from electron/reviewers as a code owner May 15, 2018

@ckerr

ckerr approved these changes May 15, 2018

@nornagon nornagon merged commit 0fb6dc7 into electron:master May 15, 2018

9 of 10 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nornagon nornagon deleted the nornagon:node-config branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment