New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix unused variable warnings in linux code #12950

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
2 participants
@nornagon
Contributor

nornagon commented May 15, 2018

No description provided.

@nornagon nornagon requested a review from electron/reviewers as a code owner May 15, 2018

@nornagon nornagon changed the title from fix: unused variable warnings in linux code to refactor: fix unused variable warnings in linux code May 15, 2018

@ckerr

It looks like these are only used by const char ClassName::GetClassName() const; accessors, so private should be enough for our current use case. Is there a rationale for making these public?

@nornagon

This comment has been minimized.

Show comment
Hide comment
@nornagon

nornagon May 15, 2018

Contributor

They're public elsewhere in chromium, I'm just following the pattern: https://chromium.googlesource.com/chromium/src/+/master/ui/views/controls/menu/menu_item_view.h#78

Contributor

nornagon commented May 15, 2018

They're public elsewhere in chromium, I'm just following the pattern: https://chromium.googlesource.com/chromium/src/+/master/ui/views/controls/menu/menu_item_view.h#78

@ckerr

ckerr approved these changes May 15, 2018

@ckerr ckerr merged commit 8fa48d1 into electron:master May 15, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nornagon nornagon deleted the nornagon:unused-variables branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment