Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary std::moves in linux code #12951

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
3 participants
@nornagon
Copy link
Contributor

nornagon commented May 15, 2018

The compiler was complaining that the move was preventing copy elision.

@nornagon nornagon requested a review from as a code owner May 15, 2018

@nornagon nornagon changed the title fix: remove unnecessary std::moves in linux code refactor: remove unnecessary std::moves in linux code May 15, 2018

@ckerr

ckerr approved these changes May 15, 2018

Copy link
Member

ckerr left a comment

the typescript CI failure is unrelated to this PR

@miniak

miniak approved these changes May 15, 2018

refactor: remove unnecessary std::moves in linux code
The compiler was complaining that the move was preventing copy elision.

@nornagon nornagon force-pushed the nornagon:unnecessary-move branch from 1e36e29 to 67b53f2 May 15, 2018

@nornagon nornagon merged commit 73eb5af into electron:master May 15, 2018

1 of 6 checks passed

ci/circleci: electron-linux-arm CircleCI is running your tests
Details
ci/circleci: electron-linux-arm64 CircleCI is running your tests
Details
ci/circleci: electron-linux-ia32 CircleCI is running your tests
Details
ci/circleci: electron-linux-x64 CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details

@nornagon nornagon deleted the nornagon:unnecessary-move branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.