New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: wrong list index type in file_dialog_gtk.cc #12952

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
2 participants
@nornagon
Contributor

nornagon commented May 15, 2018

No description provided.

@nornagon nornagon requested a review from electron/reviewers as a code owner May 15, 2018

@nornagon nornagon changed the title from fix: wrong list index type in file_dialog_gtk.cc to refactor: wrong list index type in file_dialog_gtk.cc May 15, 2018

@ckerr

ckerr approved these changes May 15, 2018

@ckerr ckerr merged commit 136105e into electron:master May 15, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment