New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty description when only one extension is given (GetFileTypesFromAcceptType) #12954

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
4 participants
@miniak
Contributor

miniak commented May 15, 2018

Fixes #12956

@miniak miniak requested a review from electron/reviewers as a code owner May 15, 2018

@jkleinsc

This comment has been minimized.

Show comment
Hide comment
@jkleinsc

jkleinsc May 15, 2018

Contributor

@miniak can you update the description of this PR with a short description of what you are changing/why you are changing it?

Contributor

jkleinsc commented May 15, 2018

@miniak can you update the description of this PR with a short description of what you are changing/why you are changing it?

@miniak miniak changed the title from GetFileTypesFromAcceptType tweaks to Fix empty description when only one extension is given (GetFileTypesFromAcceptType) May 15, 2018

@miniak

This comment has been minimized.

Show comment
Hide comment
@miniak

miniak May 15, 2018

Contributor

@jkleinsc working on it

Contributor

miniak commented May 15, 2018

@jkleinsc working on it

@miniak

This comment has been minimized.

Show comment
Hide comment
@miniak

miniak May 15, 2018

Contributor

@jkleinsc I've created a bug with more detailed information a linked it in the description.

Contributor

miniak commented May 15, 2018

@jkleinsc I've created a bug with more detailed information a linked it in the description.

@miniak

This comment has been minimized.

Show comment
Hide comment
@miniak

miniak May 15, 2018

Contributor

Chromium uses a nice description. But still using "Custom Files" for even a single file type is better than empty string.
screen shot 2018-05-16 at 1 22 54 am
screen shot 2018-05-16 at 1 23 34 am

Contributor

miniak commented May 15, 2018

Chromium uses a nice description. But still using "Custom Files" for even a single file type is better than empty string.
screen shot 2018-05-16 at 1 22 54 am
screen shot 2018-05-16 at 1 23 34 am

@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin May 15, 2018

Contributor

Would it make sense to add a DCHECK(!description.empty()) before filters[0].first = description;?

Contributor

alexeykuzmin commented May 15, 2018

Would it make sense to add a DCHECK(!description.empty()) before filters[0].first = description;?

@miniak

This comment has been minimized.

Show comment
Hide comment
@miniak

miniak May 15, 2018

Contributor

@alexeykuzmin DCHECK added

Contributor

miniak commented May 15, 2018

@alexeykuzmin DCHECK added

@jkleinsc jkleinsc merged commit e1c374d into master May 16, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 16, 2018

We have automatically backported this PR to "1-8-x", please check out #12962

trop bot commented May 16, 2018

We have automatically backported this PR to "1-8-x", please check out #12962

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 16, 2018

We have automatically backported this PR to "2-0-x", please check out #12963

trop bot commented May 16, 2018

We have automatically backported this PR to "2-0-x", please check out #12963

@trop trop bot added merged/2-0-x and removed target/2-0-x labels May 16, 2018

@jkleinsc jkleinsc deleted the web-dialog-helper branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment