New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locale setting documentation #12967

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Member

codebytere commented May 16, 2018

Some users have been attempting to call app.setLocale(), which doesn't exist as we repurposed the functionality to command line switches.

This PR links to that under the app.getLocale() doc to make the current method clearer

/cc @ckerr

@codebytere codebytere requested a review from electron/docs as a code owner May 16, 2018

@zeke

zeke approved these changes May 17, 2018

@codebytere codebytere merged commit 83993fe into master May 17, 2018

10 of 11 checks passed

ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@codebytere codebytere deleted the fix-setlocale branch May 17, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere May 21, 2018

Member

/trop run backport-to 2-0-x

Member

codebytere commented May 21, 2018

/trop run backport-to 2-0-x

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 21, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

trop bot commented May 21, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 21, 2018

We have automatically backported this PR to "2-0-x", please check out #13027

trop bot commented May 21, 2018

We have automatically backported this PR to "2-0-x", please check out #13027

@trop trop bot added the merged/2-0-x label May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment