Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs formatting for ts defs #12968

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
4 participants
@codebytere
Copy link
Member

codebytere commented May 16, 2018

The header in this PR had ### instead of #### which caused typescript header definition failures in CI.

This PR fixes that.

@codebytere codebytere requested a review from as a code owner May 16, 2018

@nitsakh

This comment has been minimized.

Copy link
Contributor

nitsakh commented May 16, 2018

😅

@codebytere codebytere merged commit f068ed9 into master May 16, 2018

6 of 11 checks passed

ci/circleci: electron-linux-ia32 CircleCI is running your tests
Details
ci/circleci: electron-linux-x64 CircleCI is running your tests
Details
ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@codebytere codebytere deleted the fix-ts-ci branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.