New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect EventEmitter in removeRemoteListenersAndLogWarning (rpc-server) #12975

Merged
merged 1 commit into from May 18, 2018

Conversation

Projects
None yet
2 participants
@miniak
Contributor

miniak commented May 17, 2018

Instead of checking for WebContents, check if the object inherits the EventEmitter, which is more robust. @zcbenz can you please review?

@miniak miniak requested a review from electron/reviewers as a code owner May 17, 2018

@zcbenz

zcbenz approved these changes May 18, 2018

👍

@zcbenz zcbenz merged commit 5a5eb43 into master May 18, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zcbenz zcbenz deleted the miniak/tweak-rpc-server-listener-cleanup branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment