Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Menu.setApplicationMenu(null) crash on Linux #12983

Merged
merged 1 commit into from May 18, 2018

Conversation

Projects
None yet
4 participants
@nornagon
Copy link
Contributor

nornagon commented May 17, 2018

I don't understand how this wasn't crashing in CI, since there's a test for this.

@nornagon nornagon requested a review from as a code owner May 17, 2018

@zcbenz

zcbenz approved these changes May 18, 2018

Copy link
Member

zcbenz left a comment

👍

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented May 18, 2018

@nornagon CI blew up :rip:

@nornagon nornagon force-pushed the nornagon:setmenu-null-crash branch from a434209 to c4d3614 May 18, 2018

@nornagon

This comment has been minimized.

Copy link
Contributor Author

nornagon commented May 18, 2018

ci fails are unrelated lint errors due to master being red.

@nornagon nornagon merged commit 156a97b into electron:master May 18, 2018

1 of 9 checks passed

ci/circleci: electron-linux-arm Your tests failed on CircleCI
Details
ci/circleci: electron-linux-arm64 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-ia32 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details

@nornagon nornagon deleted the nornagon:setmenu-null-crash branch May 18, 2018

@ckerr

This comment has been minimized.

Copy link
Member

ckerr commented May 21, 2018

/trop run backport-to 2-0-x

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented May 21, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented May 21, 2018

We have automatically backported this PR to "2-0-x", please check out #13022

@trop trop bot added the merged/2-0-x label May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.