New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document missing quit events during shutdown #12986

Merged
merged 2 commits into from May 18, 2018

Conversation

Projects
None yet
3 participants
@felixrieseberg
Member

felixrieseberg commented May 17, 2018

A simple documentation addition: I've been bitten by this before, forgot all about it, and was bitten by it again today.

We'll eventually fix the root cause properly (and deal with ``WM_QUERYENDSESSION`), but for now, we should at least warn people that you can't rely on these events to do anything that needs to happen.

felixrieseberg added some commits May 17, 2018

@felixrieseberg felixrieseberg requested a review from electron/docs as a code owner May 17, 2018

@jkleinsc

LGTM

@jkleinsc jkleinsc merged commit f087f8e into master May 18, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the felix-app-quit-hints branch May 18, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr May 21, 2018

Member

/trop run backport-to 2-0-x

Member

ckerr commented May 21, 2018

/trop run backport-to 2-0-x

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 21, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

trop bot commented May 21, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 21, 2018

We have automatically backported this PR to "2-0-x", please check out #13026

trop bot commented May 21, 2018

We have automatically backported this PR to "2-0-x", please check out #13026

@trop trop bot added the merged/2-0-x label May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment