New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't upload aliased arm builds anymore #12991

Merged
merged 1 commit into from May 18, 2018

Conversation

Projects
None yet
4 participants
@malept
Member

malept commented May 18, 2018

They are literally a copy/paste of the armv7l builds, and have been deprecated ever since they were renamed 2 years ago. (Note how the comment says TODO Remove for 2.0 馃槃)

FWIW, Electron Packager has never officially supported the arm variant.

This is technically a breaking change and should be mentioned in the release notes.

Don't upload aliased arm builds anymore
They are literally a copy/paste of the armv7l builds, and have been
deprecated ever since they were renamed 2 years ago.

@malept malept added the semver/major label May 18, 2018

@malept malept requested a review from electron/reviewers May 18, 2018

@jkleinsc

Looks good to me.

@jkleinsc jkleinsc merged commit 3fbc386 into master May 18, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the drop-arm-alias-builds branch May 18, 2018

@yurikoex

This comment has been minimized.

yurikoex commented Jul 25, 2018

On my odroid-xu4 process.arch still shows 'arm' which causes this error when installing: Error: Failed to find Electron v3.0.0-beta.3 for linux-arm at https://github.com/electron/electron/releases/download/v3.0.0-beta.3/electron-v3.0.0-beta.3-linux-arm.zip.

Are we saying this cpu/arch isn't officially supported?

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Jul 25, 2018

@yurikoex No, we're saying the the arch "arm" doesn't make sense, the actual arch of these builds is armv7l. You can set the environment variable npm_config_arch to armv7l if your node install is reporting an invalid arch

@malept

This comment has been minimized.

Member

malept commented Jul 25, 2018

To expand on the previous comment, arm as an arch name is too vague. There's also armv6l, which is the arch on the Raspberry Pi 1, which does not work with Electron. Being more specific (and conforming to the arch names that Node uses in its own downloads) is a better path forward.

Anyway, I'm working around the fact that Node reports arch as just arm in electron-userland/electron-download#77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment