Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isEventEmitter with instanceof EventEmitter (rpc-server) #12998

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
2 participants
@miniak
Copy link
Contributor

miniak commented May 18, 2018

I've just realized that I should have used instanceof EventEmitter instead of writing custom isEventEmitter function in my previous PR #12975

@miniak miniak requested a review from as a code owner May 18, 2018

@miniak miniak requested a review from zcbenz May 18, 2018

@miniak

This comment has been minimized.

Copy link
Contributor Author

miniak commented May 18, 2018

@zcbenz can you please review? Thanks

@zcbenz

zcbenz approved these changes May 21, 2018

@zcbenz zcbenz merged commit 7c19ae3 into master May 21, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zcbenz zcbenz deleted the miniak/event-emitter branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.