New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: dev instructions for GN build #13005

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
3 participants
@nornagon
Contributor

nornagon commented May 18, 2018

No description provided.

@nornagon nornagon requested a review from electron/docs as a code owner May 18, 2018

@deepak1556

LGTM, Thanks!

@nornagon

This comment has been minimized.

Show comment
Hide comment
@nornagon

nornagon May 29, 2018

Contributor

@electron/docs could we get an lgtm?

Contributor

nornagon commented May 29, 2018

@electron/docs could we get an lgtm?

@nornagon nornagon referenced this pull request May 29, 2018

Merged

Roll libchromiumcontent #13105

@zeke

zeke approved these changes May 29, 2018

I love docs. 👍

same version of node.js that was built as part of the build process.
```sh
$ (cd electron/spec && npm i --nodedir=../../third_party/electron_node)

This comment has been minimized.

@zeke

zeke May 29, 2018

Member

why the parens here?

@zeke

zeke May 29, 2018

Member

why the parens here?

This comment has been minimized.

@nornagon

nornagon May 29, 2018

Contributor

Parens create a subshell, making it so the cd doesn't effect the current shell.

$ pwd
/Users/nornagon
$ (cd work; pwd)
/Users/nornagon/work
$ pwd
/Users/nornagon
@nornagon

nornagon May 29, 2018

Contributor

Parens create a subshell, making it so the cd doesn't effect the current shell.

$ pwd
/Users/nornagon
$ (cd work; pwd)
/Users/nornagon/work
$ pwd
/Users/nornagon

@zeke zeke merged commit cb9ab21 into electron:master May 29, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nornagon nornagon deleted the nornagon:gn-docs branch May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment