New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removal of 3.0.0 deprecations #13050

Merged
merged 19 commits into from May 30, 2018

Conversation

Projects
None yet
5 participants
@codebytere
Member

codebytere commented May 23, 2018

This PR removes deprecations for Electron 3.0.0 previously specified in planned breaking changes.

/cc @electron/electrocats

codebytere added some commits May 23, 2018

@codebytere codebytere requested review from electron/docs as code owners May 23, 2018

codebytere added some commits May 23, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere May 23, 2018

Member

TS defns are dying, I’ll investigate

Member

codebytere commented May 23, 2018

TS defns are dying, I’ll investigate

codebytere added some commits May 23, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere May 23, 2018

Member

I'm most unsure about the blinkFeatures commit in terms of whether or not i renamed everything correctly.

This PR is also temporarily blocked pending new release of electron-ts-defs following merge of electron/electron-typescript-definitions#104.

Member

codebytere commented May 23, 2018

I'm most unsure about the blinkFeatures commit in terms of whether or not i renamed everything correctly.

This PR is also temporarily blocked pending new release of electron-ts-defs following merge of electron/electron-typescript-definitions#104.

@codebytere codebytere changed the title from [WIP] Removal of 3.0.0 deprecations to Removal of 3.0.0 deprecations May 23, 2018

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke May 23, 2018

Member

So cool to see this kind of thing happening.

✂️ 🌹

Member

zeke commented May 23, 2018

So cool to see this kind of thing happening.

✂️ 🌹

Show outdated Hide outdated docs/api/native-image.md
Show outdated Hide outdated lib/renderer/security-warnings.js
Show outdated Hide outdated lib/renderer/security-warnings.js

codebytere added some commits May 23, 2018

@codebytere codebytere changed the title from Removal of 3.0.0 deprecations to chore: removal of 3.0.0 deprecations May 25, 2018

codebytere added some commits May 25, 2018

@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin May 29, 2018

Contributor
../../atom/browser/api/atom_api_web_contents.cc:1299:10: error: unused variable 'detach' [-Werror,-Wunused-variable]
    bool detach = false;
Contributor

alexeykuzmin commented May 29, 2018

../../atom/browser/api/atom_api_web_contents.cc:1299:10: error: unused variable 'detach' [-Werror,-Wunused-variable]
    bool detach = false;
@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere May 29, 2018

Member

fixing CI errors 👇

Member

codebytere commented May 29, 2018

fixing CI errors 👇

codebytere added some commits May 29, 2018

@ckerr

ckerr approved these changes May 30, 2018

@ckerr ckerr merged commit b89fe86 into master May 30, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the 3.0.0-deprecations branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment