New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload symbols script for posix #13058

Merged
merged 1 commit into from May 24, 2018

Conversation

Projects
None yet
2 participants
@nitsakh
Contributor

nitsakh commented May 24, 2018

This PR resolves #10105.
The symbol upload script which worked only for windows previously, now uploads other platform symbols also.

@nitsakh nitsakh requested a review from electron/reviewers as a code owner May 24, 2018

@jkleinsc

Looks good to me. I'll run test release builds to verify this change.

@jkleinsc

This comment has been minimized.

Show comment
Hide comment
@jkleinsc

jkleinsc May 24, 2018

Contributor

I tested this with release builds and the symbols upload as expected.

Contributor

jkleinsc commented May 24, 2018

I tested this with release builds and the symbols upload as expected.

@jkleinsc jkleinsc merged commit 8bf7ec0 into master May 24, 2018

13 checks passed

VSTS: nightly-release-mas-x64 20180524.3 succeeded
Details
VSTS: nightly-release-osx-x64 20180524.3 succeeded
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the symserver-posix branch May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment