Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload symbols script for posix #13058

Merged
merged 1 commit into from May 24, 2018
Merged

Update upload symbols script for posix #13058

merged 1 commit into from May 24, 2018

Conversation

nitsakh
Copy link
Contributor

@nitsakh nitsakh commented May 24, 2018

This PR resolves #10105.
The symbol upload script which worked only for windows previously, now uploads other platform symbols also.

@nitsakh nitsakh requested a review from a team May 24, 2018 06:20
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll run test release builds to verify this change.

@jkleinsc
Copy link
Contributor

I tested this with release builds and the symbols upload as expected.

@jkleinsc jkleinsc merged commit 8bf7ec0 into master May 24, 2018
@jkleinsc jkleinsc deleted the symserver-posix branch May 24, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacOS symbols are not supported by Electron symbol server
2 participants