New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tray title not inverting when highlighted #13085

Merged
merged 1 commit into from Jun 16, 2018

Conversation

Projects
None yet
4 participants
@mikeykhalil
Contributor

mikeykhalil commented May 27, 2018

Fixes #12960

/cc @codebytere

I didn't notice that you were assigned to this issue until after I started digging into it. Feel free to close this PR if you already have a fix in mind or if my fix seems unreasonable.

I noticed that just adding [self updateAttributedTitle]; in a few strategic places did the trick. However, I feel like it makes more sense to just update the attributed title whenever we redraw the icon. Probably less efficient this way though.

@mikeykhalil mikeykhalil requested a review from electron/reviewers as a code owner May 27, 2018

@ckerr ckerr requested a review from codebytere May 29, 2018

@codebytere

This comment has been minimized.

Member

codebytere commented Jun 15, 2018

hey this is great! no worries at all, thanks for checking into this 😁

@codebytere

🚀

@MarshallOfSound MarshallOfSound merged commit ef1e2d6 into electron:master Jun 16, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@trop

This comment has been minimized.

Contributor

trop bot commented Jun 16, 2018

We have automatically backported this PR to "2-0-x", please check out #13262

@trop trop bot added merged/2-0-x and removed target/2-0-x labels Jun 16, 2018

@mikeykhalil mikeykhalil deleted the mikeykhalil:12960-tray-title-highlight branch Jun 16, 2018

@alexcroox

This comment has been minimized.

alexcroox commented Sep 18, 2018

Thank you for fixing my issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment