New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly rewrite <webview> tag tests #13122

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
2 participants
@alexeykuzmin
Contributor

alexeykuzmin commented May 31, 2018

  • make "disableguestresize attribute" tests more reliable by waiting for a webview 'did-finish-load' event before running any checks;
  • make sure that there's always only one BrowserWindow opened, afterEach hook is not reliable;
  • more async/await stuff.

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner May 31, 2018

@alexeykuzmin alexeykuzmin requested a review from codebytere May 31, 2018

@alexeykuzmin alexeykuzmin changed the title from Slightly rewrite <webview> tag tests to [wip] Slightly rewrite <webview> tag tests May 31, 2018

@alexeykuzmin alexeykuzmin changed the title from [wip] Slightly rewrite <webview> tag tests to Slightly rewrite <webview> tag tests May 31, 2018

@codebytere

🚀

@codebytere codebytere merged commit 0d5e98a into master Jun 1, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@codebytere codebytere deleted the slightly-rewrite-webview-tests branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment