Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [gn] Build node by calling ./configure #13124

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
2 participants
@nornagon
Copy link
Contributor

nornagon commented May 31, 2018

Instead of committing a bespoke .gypi file presumably generated at some point by node's ./configure and then tweaked, just call ./configure directly as part of the build process.

Depends on electron/node#37

@nornagon nornagon requested a review from as a code owner May 31, 2018

@nornagon nornagon force-pushed the nornagon:node-configure branch from 6d0a824 to 4321db4 May 31, 2018

@ckerr

This comment has been minimized.

Copy link
Member

ckerr commented Jun 1, 2018

👍 on the concept: this avoids repetition and makes it easier to see which things we've explicitly changed.

Just to make sure I understand the status of the PR: the options in the older bespoke version, e.g. the disabled compilation warnings, are in the upstream already and our compile-time flags are unchanged, is that correct?

@nornagon

This comment has been minimized.

Copy link
Contributor Author

nornagon commented Jun 1, 2018

I haven't compared the compile flags precisely (in particular, not on windows), but disabling warnings should be less of a concern in the GN build because the node build shells out to gyp, and doesn't build with -Werror.

@ckerr

ckerr approved these changes Jun 1, 2018

@ckerr ckerr merged commit 6301582 into electron:master Jun 1, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.