New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify docs #13142

Merged
merged 1 commit into from Jun 3, 2018

Conversation

Projects
None yet
3 participants
@pravdomil
Contributor

pravdomil commented Jun 2, 2018

term "clear colors" is confusing

@pravdomil pravdomil requested a review from electron/docs as a code owner Jun 2, 2018

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Jun 2, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix, OR prefix at least one of your commit messages.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Jun 2, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix, OR prefix at least one of your commit messages.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@pravdomil pravdomil changed the title from clarify docs to docs: clarify docs Jun 2, 2018

@zeke

zeke approved these changes Jun 2, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Jun 3, 2018

Member

The CI failures in this PR are flakes unrelated to the PR

Member

ckerr commented Jun 3, 2018

The CI failures in this PR are flakes unrelated to the PR

@ckerr ckerr merged commit 828545c into electron:master Jun 3, 2018

8 of 10 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Jun 3, 2018

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Jun 3, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment