Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tray icon bounds didn't allow negative macOS #13162

Merged
merged 1 commit into from Jun 7, 2018

Conversation

Projects
None yet
3 participants
@mdpetuum
Copy link
Contributor

mdpetuum commented Jun 5, 2018

Tray bounds on MacOS returns 0. This is causing issues when using multiple monitors that are 'above' your main screen. The bounds returned are relative, so their y-value will be negative.

This solves this issue: #11709

@mdpetuum mdpetuum requested a review from as a code owner Jun 5, 2018

@welcome

This comment has been minimized.

Copy link

welcome bot commented Jun 5, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix, OR prefix at least one of your commit messages.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codebytere
Copy link
Member

codebytere left a comment

Are there cases where a negative y-val would cause negative unintended side effects?

@mdpetuum

This comment has been minimized.

Copy link
Contributor Author

mdpetuum commented Jun 7, 2018

@codebytere possibly, but from my perspective those are problems that should be solved in the context that they appear, not from some hard coded clause in a bounds function.

@codebytere
Copy link
Member

codebytere left a comment

I agree, and in that case am comfortable removing this conditional 🚀

@codebytere codebytere merged commit 1b8790a into electron:master Jun 7, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Jun 7, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.