New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autofill popups spawned from webviews #13184

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
4 participants
@brenca
Member

brenca commented Jun 7, 2018

This PR fixes the positioning issues and the OSR crash mentioned in #12528

@brenca brenca requested a review from electron/reviewers as a code owner Jun 7, 2018

@codebytere codebytere changed the title from Fix autofill popups spawned from webviews to src: fix autofill popups spawned from webviews Jun 13, 2018

@codebytere codebytere changed the title from src: fix autofill popups spawned from webviews to fix: autofill popups spawned from webviews Jun 13, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Jun 17, 2018

Member

@brenca is it at all possible to add a test for this?

Member

codebytere commented Jun 17, 2018

@brenca is it at all possible to add a test for this?

@zcbenz

zcbenz approved these changes Jun 18, 2018

@ckerr

ckerr approved these changes Jun 18, 2018

@ckerr ckerr merged commit 90911a4 into master Jun 18, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the fix-12528 branch Jun 18, 2018

@brenca

This comment has been minimized.

Show comment
Hide comment
@brenca

brenca Jun 18, 2018

Member

@codebytere For the crash, sure, for the positioning problems, not so much, that's a purely visual.

Member

brenca commented Jun 18, 2018

@codebytere For the crash, sure, for the positioning problems, not so much, that's a purely visual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment