Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link to commit message guidelines #13233

Merged
merged 2 commits into from Jun 16, 2018

Conversation

Projects
None yet
3 participants
@HashimotoYT
Copy link
Member

HashimotoYT commented Jun 13, 2018

This pull request, fixes broken link to commit message guideline documentation, also fixes link to not found paragraph in Contributing file.

Fixes #13230

@HashimotoYT HashimotoYT requested a review from electron/electrocats as a code owner Jun 13, 2018

@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Jun 13, 2018

Thanks, appreciate this! While you're at it, could you please run

$ npm run lint-docs-relative-links

and correct any broken links you see there as well?

@HashimotoYT HashimotoYT requested a review from as a code owner Jun 13, 2018

@codebytere
Copy link
Member

codebytere left a comment

awesome, thanks!

@ckerr

ckerr approved these changes Jun 16, 2018

@ckerr ckerr merged commit a67c992 into electron:master Jun 16, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Jun 16, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@HashimotoYT HashimotoYT deleted the HashimotoYT:docs-fix-dead-link branch Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.