New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: run tests on release builds #13241

Merged
merged 2 commits into from Jun 14, 2018

Conversation

Projects
None yet
3 participants
@jkleinsc
Contributor

jkleinsc commented Jun 13, 2018

This PR changes our CI to run tests on release builds. We currently run nightly release builds and it makes sense to run tests on those builds. This PR also adds the ability to call VSTS release builds via API.

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Jun 13, 2018

jkleinsc added some commits Jun 13, 2018

Run tests on release builds
Also, added ability to call VSTS release builds via API.

@codebytere codebytere changed the title from Run tests on release builds to spec: run tests on release builds Jun 14, 2018

@jkleinsc jkleinsc merged commit fa79b40 into master Jun 14, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the test-releases branch Jun 14, 2018

SlackApiToken: '$(slack_token)'
Channel: '#bot-nightly-releases'
Message: '$(Build.DefinitionName)-$(Build.BuildNumber) finished with a $(Agent.JobStatus) status.'
condition: and(always(), eq(variables['Build.Reason'], 'Schedule'))

This comment has been minimized.

@nornagon

nornagon Jun 18, 2018

Contributor

why and(always(), X)? isn't that exactly equivalent to just X?

@nornagon

nornagon Jun 18, 2018

Contributor

why and(always(), X)? isn't that exactly equivalent to just X?

This comment has been minimized.

@jkleinsc

jkleinsc Jun 18, 2018

Contributor

@nornagon default is success, not always so for tasks that should always run you have to explicitly declare it

@jkleinsc

jkleinsc Jun 18, 2018

Contributor

@nornagon default is success, not always so for tasks that should always run you have to explicitly declare it

@jkleinsc jkleinsc referenced this pull request Jun 19, 2018

Merged

build:Fix VSTS config for release builds #13292

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment