Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change c++ std from gnu++14 to c++14 #13248

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
3 participants
@ckerr
Copy link
Member

ckerr commented Jun 14, 2018

Does what it says on the tin.

We have been building with c++14 plus gnu extensions. Since we don't seem to be using the gnu extensions, this patch changes the standard to stock c++14.

NB: This only modifies toolchain.gypi. I haven't looked to see if this is an issue in the new build. @nornagon?

@ckerr ckerr requested a review from as a code owner Jun 14, 2018

@ckerr ckerr requested a review from nornagon Jun 14, 2018

@nitsakh
Copy link
Contributor

nitsakh left a comment

👍

@miniak

miniak approved these changes Jun 14, 2018

@ckerr ckerr merged commit 2d15b8f into master Jun 15, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the use-std-c++-14 branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.