New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: update callback registry spec to expect #13263

Merged
merged 3 commits into from Jun 17, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Jun 16, 2018

Ongoing work to migrate our specs from assert to chai's expect for better error messages.

This PR updates the callback- registry spec.

codebytere added some commits Jun 16, 2018

@codebytere codebytere requested a review from electron/reviewers as a code owner Jun 16, 2018

@codebytere codebytere merged commit c5c571f into master Jun 17, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@codebytere codebytere deleted the expect-callback-reg-spec branch Jun 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment