Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: convert debugger spec to expect #13267

Merged
merged 4 commits into from Jun 19, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

codebytere commented Jun 17, 2018

Ongoing work to migrate our specs from assert to chai's expect for better error messages.

This PR updates the debugger spec.

@codebytere codebytere requested a review from as a code owner Jun 17, 2018

@@ -78,57 +83,62 @@ describe('debugger module', () => {
}
})

it('retuns response', (done) => {
it('returns response', done => {

This comment has been minimized.

@alexeykuzmin

alexeykuzmin Jun 18, 2018

Contributor

👍

assert.equal(res.result.value, 6)

const callback = (err, res) => {
expect(err.message).to.not.exist()

This comment has been minimized.

@alexeykuzmin

alexeykuzmin Jun 18, 2018

Contributor

There shouldn't be a message property on err?
Or it should be there but have a value of null or undefined?

This comment has been minimized.

@codebytere

codebytere Jun 18, 2018

Author Member

it should be undefined :)


const callback = (err, res) => {
expect(err.message).to.not.exist()
expect(res.wasThrown).to.be.undefined()

This comment has been minimized.

@alexeykuzmin

alexeykuzmin Jun 18, 2018

Contributor

The same question as for the message above.

This comment has been minimized.

@codebytere

codebytere Jun 18, 2018

Author Member

this should also be undefined

@alexeykuzmin alexeykuzmin changed the title spec: convert debugger spec to expect [wip] spec: convert debugger spec to expect Jun 18, 2018

@alexeykuzmin alexeykuzmin changed the title [wip] spec: convert debugger spec to expect spec: convert debugger spec to expect Jun 19, 2018

@jkleinsc jkleinsc merged commit 36c1e4c into master Jun 19, 2018

1 of 8 checks passed

ci/circleci: electron-linux-arm CircleCI is running your tests
Details
ci/circleci: electron-linux-arm64 CircleCI is running your tests
Details
ci/circleci: electron-linux-ia32 CircleCI is running your tests
Details
ci/circleci: electron-linux-x64 CircleCI is running your tests
Details
ci/circleci: electron-mas-x64 Your tests are queued behind your running builds
Details
ci/circleci: electron-osx-x64 Your tests are queued behind your running builds
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details

@jkleinsc jkleinsc deleted the expect-debugger-spec branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.