New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: convert deprecations to expect #13268

Merged
merged 2 commits into from Jun 19, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Member

codebytere commented Jun 17, 2018

Ongoing work to migrate our specs from assert to chai's expect for better error messages.

This PR updates the deprecations spec.

@codebytere codebytere requested a review from electron/reviewers as a code owner Jun 17, 2018

Show outdated Hide outdated spec/api-deprecations-spec.js
Show outdated Hide outdated spec/api-deprecations-spec.js

@alexeykuzmin alexeykuzmin changed the title from spec: convert deprecations to expect to [wip] spec: convert deprecations to expect Jun 18, 2018

@alexeykuzmin alexeykuzmin changed the title from [wip] spec: convert deprecations to expect to spec: convert deprecations to expect Jun 19, 2018

@ckerr ckerr merged commit cba3a9f into master Jun 19, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the expect-deprecations-spec branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment