New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update pr template with checklist #13270

Merged
merged 4 commits into from Jun 18, 2018

Conversation

Projects
None yet
7 participants
@codebytere
Member

codebytere commented Jun 17, 2018

This PR updates the Pull Request template so that contributors see a clearer checklist of items they need to complete in order to have a given PR reviewed and landed.

@codebytere codebytere requested a review from electron/electrocats as a code owner Jun 17, 2018

@jkleinsc

@codebytere great idea. Would it be redundant to add a checkmark for adding a description to the PR?

@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin Jun 18, 2018

Contributor

The idea is stolen from Node, isn't it? =)

Contributor

alexeykuzmin commented Jun 18, 2018

The idea is stolen from Node, isn't it? =)

Show outdated Hide outdated .github/PULL_REQUEST_TEMPLATE.md
Show outdated Hide outdated .github/PULL_REQUEST_TEMPLATE.md
@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Jun 18, 2018

Member

@alexeykuzmin yes indeed 😁

Member

codebytere commented Jun 18, 2018

@alexeykuzmin yes indeed 😁

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Jun 18, 2018

Member

@jkleinsc good idea, i was just concerned about being too pedantic

how about something like
- [ ] PR description included and relevant parties cc'd?

Member

codebytere commented Jun 18, 2018

@jkleinsc good idea, i was just concerned about being too pedantic

how about something like
- [ ] PR description included and relevant parties cc'd?

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Jun 18, 2018

Member

👍 but s/relevant parties/stakeholders/

Member

ckerr commented Jun 18, 2018

👍 but s/relevant parties/stakeholders/

@ckerr

ckerr approved these changes Jun 18, 2018

@sofianguy

This comment has been minimized.

Show comment
Hide comment
@sofianguy

sofianguy Jun 18, 2018

Member

@codebytere I don't think it's too much to ask for a description and parties cc'd

Member

sofianguy commented Jun 18, 2018

@codebytere I don't think it's too much to ask for a description and parties cc'd

@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin Jun 18, 2018

Contributor

and relevant parties cc'd

I agree to @sofianguy, all required reviewers will be added automatically, all others are, by definition, optional )

Contributor

alexeykuzmin commented Jun 18, 2018

and relevant parties cc'd

I agree to @sofianguy, all required reviewers will be added automatically, all others are, by definition, optional )

@codebytere codebytere merged commit adea26b into master Jun 18, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@codebytere codebytere deleted the update-pr-template branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment