New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: convert IAP and GC specs to expect #13272

Merged
merged 2 commits into from Jun 18, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Jun 18, 2018

Ongoing work to migrate our specs from assert to chai's expect for better error messages.

This PR groups two small specs: global-shortcut and in-app-purchase

@codebytere codebytere requested a review from electron/reviewers as a code owner Jun 18, 2018

Show outdated Hide outdated spec/api-global-shortcut-spec.js
Show outdated Hide outdated spec/api-in-app-purchase-spec.js

@codebytere codebytere merged commit b4cce8e into master Jun 18, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@codebytere codebytere deleted the expect-specs branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment