New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - fix: prevent bundles from being selected in <input file="type"> open file dialog (macOS) #13277

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
3 participants
@miniak
Contributor

miniak commented Jun 18, 2018

Backport: #13220

@miniak miniak requested a review from electron/reviewers as a code owner Jun 18, 2018

@ckerr

ckerr approved these changes Jun 18, 2018

@ckerr ckerr merged commit a09fa53 into 2-0-x Jun 18, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the miniak/open-dialog-fix-2-0-x branch Jun 18, 2018

@yume-chan

This comment has been minimized.

Show comment
Hide comment
@yume-chan

yume-chan Jun 22, 2018

You have (almost) broken the Electron release page:

https://electronjs.org/releases#2.0.3

image

But you made a typo, <input file="type"> should be <input type="file">, and it now displays as a text input.

yume-chan commented Jun 22, 2018

You have (almost) broken the Electron release page:

https://electronjs.org/releases#2.0.3

image

But you made a typo, <input file="type"> should be <input type="file">, and it now displays as a text input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment