Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix chromium-style in url_request_asar_job #13284

Merged
merged 1 commit into from Jun 19, 2018

Conversation

Projects
None yet
3 participants
@nornagon
Copy link
Contributor

nornagon commented Jun 18, 2018

Chromium-style was failing on this file. Now it isn't.

@nornagon nornagon requested a review from as a code owner Jun 18, 2018

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Jun 18, 2018

@nornagon can you add a short description to this PR? Thanks!

@nornagon

This comment has been minimized.

Copy link
Contributor Author

nornagon commented Jun 18, 2018

@jkleinsc done, though I'm not sure I know what your confusion was. Is there anything you'd like clarification on?

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Jun 19, 2018

@nornagon it makes it easier to put together the release notes when there is a description provided. Does Chromium-style checking happen automatically with the GN builds?

@ckerr

ckerr approved these changes Jun 19, 2018

@ckerr ckerr merged commit 9e8f83e into electron:master Jun 19, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nornagon nornagon deleted the nornagon:chromium-style branch Jun 19, 2018

@nornagon

This comment has been minimized.

Copy link
Contributor Author

nornagon commented Jun 19, 2018

@jkleinsc i feel like the description i added did nothing to expand on the commit title; is there a tool you're using that's particular about empty descriptions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.