New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: slightly rewrite webview tests #13291

Merged
merged 2 commits into from Jun 19, 2018

Conversation

Projects
None yet
3 participants
@alexeykuzmin
Contributor

alexeykuzmin commented Jun 19, 2018

Light refactoring of the <webview> tag tests.

Checklist

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner Jun 19, 2018

@alexeykuzmin alexeykuzmin requested a review from codebytere Jun 19, 2018

@zeke

zeke approved these changes Jun 19, 2018

@jkleinsc jkleinsc merged commit be29a19 into master Jun 19, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the slightly-rewrite-webview-tests branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment