New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update submodule reference for libchromiumcontent #13305

Merged
merged 1 commit into from Jun 20, 2018

Conversation

Projects
None yet
4 participants
@ckerr
Member

ckerr commented Jun 19, 2018

Bump the libcc submodule reference to electron/libchromiumcontent@14ff5b5

@alexeykuzmin @miniak

@ckerr ckerr requested a review from electron/reviewers as a code owner Jun 19, 2018

@ckerr ckerr changed the title from update submodule referefence for libchromiumcontent to [WIP] update submodule referefence for libchromiumcontent Jun 19, 2018

@codebytere codebytere changed the title from [WIP] update submodule referefence for libchromiumcontent to [WIP] update submodule reference for libchromiumcontent Jun 19, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Jun 19, 2018

Member

both mac builds failed, just kicked em again

Member

codebytere commented Jun 19, 2018

both mac builds failed, just kicked em again

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Jun 20, 2018

Member

Not sure what's WIP but not merging for now, merge at will @ckerr 😀

Member

MarshallOfSound commented Jun 20, 2018

Not sure what's WIP but not merging for now, merge at will @ckerr 😀

@jkleinsc jkleinsc changed the title from [WIP] update submodule reference for libchromiumcontent to update submodule reference for libchromiumcontent Jun 20, 2018

@jkleinsc jkleinsc merged commit 989c260 into 2-0-x Jun 20, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the 2-0-x_update-libcc-subreference branch Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment