refactor: clean up the default app, add CSP #13437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiru
reviewed
Jun 26, 2018
tools/js2asar.py
Outdated
| @@ -24,6 +24,10 @@ def main(): | |||
| def copy_files(source_files, output_dir): | |||
| for source_file in source_files: | |||
| output_path = os.path.join(output_dir, source_file) | |||
| # Files that aren't in the default_app folder need to be put inside | |||
| # the temp one we are making so they end up in the ASAR | |||
| if source_file[:12] != "default_app/": | |||
There was a problem hiding this comment.
!source_file.startswith("default_app/") would be a little cleaner, I think.
|
Do we want to commit the package lock here? |
|
@codebytere Yeah, an extra dependency was added so the lock was updated 馃憤 |
MarshallOfSound
force-pushed
the
clean-up-default-app
branch
from
e22cdfa
to
a55f34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got fed up seeing the CSP warnings when launching the default app 馃槃
This PR: