New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (3-0-x) - fix: do not expose Node's external strings #13452

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@trop

trop bot commented Jun 27, 2018

Backport of #13438

See that PR for details.

@trop trop bot requested a review from electron/reviewers as a code owner Jun 27, 2018

@trop trop bot added the backport label Jun 27, 2018

@zcbenz zcbenz merged commit 21d4ef5 into electron:3-0-x Jun 27, 2018

8 of 9 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@electron electron deleted a comment from creatorliao Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment