New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - fix: tray setContextMenu crash #13516

Merged
merged 1 commit into from Jul 2, 2018

Conversation

Projects
None yet
2 participants
@trop

trop bot commented Jun 29, 2018

Backport of #13513

See that PR for details.

fix: tray setContextMenu crash
Co-authored-by: Zhuo Lu <sethlu@mintkit.net>
Co-authored-by: Kristine Zhang <kzhang@slack-corp.com>

@trop trop bot requested a review from electron/reviewers as a code owner Jun 29, 2018

@trop trop bot referenced this pull request Jun 29, 2018

Merged

fix: tray setContextMenu crash #13513

3 of 3 tasks complete

@trop trop bot added the backport label Jun 29, 2018

@jkleinsc jkleinsc merged commit abcba2b into electron:2-0-x Jul 2, 2018

8 of 10 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-osx-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

GitSquared added a commit to GitSquared/edex-ui that referenced this pull request Jul 5, 2018

Update electron to the latest version 🚀 (#115)

## Version **2.0.4** of **electron** was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </th>
    <td>
      <a target=_blank href=https://github.com/electron/electron>electron</a>
    </td>
  </tr>
  <tr>
      <th align=left>
       Current Version
      </th>
      <td>
        2.0.3
      </td>
    </tr>
  <tr>
    <th align=left>
      Type
    </th>
    <td>
      dependency
    </td>
  </tr>
</table>



The version **2.0.4** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of electron.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Release Notes</summary>
<strong>electron v2.0.4</strong>

<h2>Bug Fixes</h2>
<ul>
<li>Fixed crashes in V8 garbage collector. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="335502558" data-permission-text="Issue title is private" data-url="electron/electron#13421" href="https://urls.greenkeeper.io/electron/electron/pull/13421">#13421</a></li>
<li>Fixed issue where cookies and credentials were being captured in netlog. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="337567636" data-permission-text="Issue title is private" data-url="electron/electron#13537" href="https://urls.greenkeeper.io/electron/electron/pull/13537">#13537</a></li>
</ul>
<h3>macOS</h3>
<ul>
<li>Fixed crash on startup on macOS 10.9 due to linking with CoreBluetooth. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="337788399" data-permission-text="Issue title is private" data-url="electron/electron#13545" href="https://urls.greenkeeper.io/electron/electron/pull/13545">#13545</a></li>
<li>Fixed <code>tray.setContextMenu</code> crash. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="337147553" data-permission-text="Issue title is private" data-url="electron/electron#13516" href="https://urls.greenkeeper.io/electron/electron/pull/13516">#13516</a></li>
</ul>
<h3>Windows</h3>
<ul>
<li>Fixed windows causing repaint issues when DWM composition is disabled. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310462684" data-permission-text="Issue title is private" data-url="electron/electron#12501" href="https://urls.greenkeeper.io/electron/electron/pull/12501">#12501</a></li>
</ul>
</details>


<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment