New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (3-0-x) - fix: tray setContextMenu crash #13517

Merged
merged 1 commit into from Jul 2, 2018

Conversation

Projects
None yet
2 participants
@trop

trop bot commented Jun 29, 2018

Backport of #13513

See that PR for details.

fix: tray setContextMenu crash
Co-authored-by: Zhuo Lu <sethlu@mintkit.net>
Co-authored-by: Kristine Zhang <kzhang@slack-corp.com>

@trop trop bot requested a review from electron/reviewers as a code owner Jun 29, 2018

@trop trop bot referenced this pull request Jun 29, 2018

Merged

fix: tray setContextMenu crash #13513

3 of 3 tasks complete

@trop trop bot added the backport label Jun 29, 2018

@jkleinsc jkleinsc merged commit 8585372 into electron:3-0-x Jul 2, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment