New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on startup on macOS 10.9 due to linking with CoreBluetooth #13545

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
4 participants
@zcbenz
Contributor

zcbenz commented Jul 3, 2018

From https://cs.chromium.org/chromium/src/device/BUILD.gn?type=cs&q=CoreBluetooth&sq=package:chromium&g=0&l=267-276:

    # In the OSX 10.10 SDK, CoreBluetooth became a top level framework.
    # Previously, it was nested in IOBluetooth. In order for Chrome to run on
    # OSes older than OSX 10.10, the top level CoreBluetooth framework must be
    # weakly linked.

This may not entirely be able to fix the #13459, since according to #13404 we also have a problem with our build machine configuration.

fix: weak load CoreBluetooth when building with 10.10 SDK
The CoreBluetooth framework does not exist on OS X 10.9.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Jul 3, 2018

@poiru

poiru approved these changes Jul 3, 2018

@jkleinsc jkleinsc merged commit 91be3f3 into 2-0-x Jul 3, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the fix-core-bluetooth-linking branch Jul 3, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Jul 3, 2018

Member

@zcbenz do we need this on >= 3-0-x as well?

Member

ckerr commented Jul 3, 2018

@zcbenz do we need this on >= 3-0-x as well?

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Jul 4, 2018

Contributor

@ckerr 3-0-x is using 10.12 SDK, from Chromium's build configuration it is not needed there.

Contributor

zcbenz commented Jul 4, 2018

@ckerr 3-0-x is using 10.12 SDK, from Chromium's build configuration it is not needed there.

GitSquared added a commit to GitSquared/edex-ui that referenced this pull request Jul 5, 2018

Update electron to the latest version 🚀 (#115)

## Version **2.0.4** of **electron** was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </th>
    <td>
      <a target=_blank href=https://github.com/electron/electron>electron</a>
    </td>
  </tr>
  <tr>
      <th align=left>
       Current Version
      </th>
      <td>
        2.0.3
      </td>
    </tr>
  <tr>
    <th align=left>
      Type
    </th>
    <td>
      dependency
    </td>
  </tr>
</table>



The version **2.0.4** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of electron.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Release Notes</summary>
<strong>electron v2.0.4</strong>

<h2>Bug Fixes</h2>
<ul>
<li>Fixed crashes in V8 garbage collector. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="335502558" data-permission-text="Issue title is private" data-url="electron/electron#13421" href="https://urls.greenkeeper.io/electron/electron/pull/13421">#13421</a></li>
<li>Fixed issue where cookies and credentials were being captured in netlog. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="337567636" data-permission-text="Issue title is private" data-url="electron/electron#13537" href="https://urls.greenkeeper.io/electron/electron/pull/13537">#13537</a></li>
</ul>
<h3>macOS</h3>
<ul>
<li>Fixed crash on startup on macOS 10.9 due to linking with CoreBluetooth. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="337788399" data-permission-text="Issue title is private" data-url="electron/electron#13545" href="https://urls.greenkeeper.io/electron/electron/pull/13545">#13545</a></li>
<li>Fixed <code>tray.setContextMenu</code> crash. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="337147553" data-permission-text="Issue title is private" data-url="electron/electron#13516" href="https://urls.greenkeeper.io/electron/electron/pull/13516">#13516</a></li>
</ul>
<h3>Windows</h3>
<ul>
<li>Fixed windows causing repaint issues when DWM composition is disabled. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310462684" data-permission-text="Issue title is private" data-url="electron/electron#12501" href="https://urls.greenkeeper.io/electron/electron/pull/12501">#12501</a></li>
</ul>
</details>


<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment