New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update to latest libchromiumcontent for 3-0-x #13593

Merged
merged 1 commit into from Jul 9, 2018

Conversation

Projects
None yet
2 participants
@jkleinsc
Contributor

jkleinsc commented Jul 9, 2018

Use the latest libchromiumcontent for 3-0-x which is built with Visual Studio 2017 15.7.4

Fixes #13409

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • commit messages or PR title follow semantic commit guidelines
Update to latest libchromiumcontent
Use the latest libchromiumcontent for 3-0-x which is built with Visual Studio 2017 15.7.4

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Jul 9, 2018

@deepak1556

This comment has been minimized.

Show comment
Hide comment
@deepak1556

deepak1556 Jul 9, 2018

Member

The ssl issue reported in #13375 is not present with this build, same for local release build. This clearly seems to be a build time issue that happened with 3.0.0-beta.1, not sure what exactly could have caused it. /cc @felixrieseberg @ckerr

Member

deepak1556 commented Jul 9, 2018

The ssl issue reported in #13375 is not present with this build, same for local release build. This clearly seems to be a build time issue that happened with 3.0.0-beta.1, not sure what exactly could have caused it. /cc @felixrieseberg @ckerr

@deepak1556

Thanks!

@jkleinsc jkleinsc merged commit 5e51e60 into 3-0-x Jul 9, 2018

11 of 13 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details

@jkleinsc jkleinsc deleted the update-libcc-3-0-x branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment