Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guard against double-freeing remote references (2-0-x) #13604

Merged
merged 3 commits into from Jul 12, 2018

Conversation

Projects
None yet
1 participant
@zcbenz
Copy link
Member

zcbenz commented Jul 10, 2018

Backports #13603 to 2-0-x branch.

@zcbenz zcbenz requested a review from Jul 10, 2018

@zcbenz zcbenz force-pushed the fix-remote-2-0-x branch from 2b52219 to 0a729b9 Jul 11, 2018

@zcbenz zcbenz changed the title Fix double-freeing remote references (2-0-x) fix double-freeing remote references (2-0-x) Jul 11, 2018

@zcbenz zcbenz changed the title fix double-freeing remote references (2-0-x) Fix double-freeing remote references (2-0-x) Jul 11, 2018

@zcbenz zcbenz changed the title Fix double-freeing remote references (2-0-x) fix: guard against double-freeing remote references (2-0-x) Jul 11, 2018

@zcbenz zcbenz force-pushed the fix-remote-2-0-x branch from 0a729b9 to c82cb7b Jul 11, 2018

zcbenz added some commits Jul 10, 2018

fix double-freeing remote references
After the page does navigations, garbage collection can still happen in
the old context. This commit changes to store references to remote objects
by _pages_, instead of by _WebContents_.

@zcbenz zcbenz force-pushed the fix-remote-2-0-x branch from c82cb7b to 3db1b5a Jul 12, 2018

@zcbenz zcbenz merged commit 05a7485 into 2-0-x Jul 12, 2018

14 checks passed

Semantic Pull Request good to go
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@zcbenz zcbenz deleted the fix-remote-2-0-x branch Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.