Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guard against double-freeing remote references (3-0-x) #13637

Merged
merged 2 commits into from Jul 12, 2018

Conversation

1 participant
@zcbenz
Copy link
Member

zcbenz commented Jul 12, 2018

Backport #13603 to 3-0-x.

zcbenz added some commits Jul 10, 2018

fix double-freeing remote references
After the page does navigations, garbage collection can still happen in
the old context. This commit changes to store references to remote objects
by _pages_, instead of by _WebContents_.

@zcbenz zcbenz requested a review from Jul 12, 2018

@zcbenz zcbenz merged commit e3204a5 into 3-0-x Jul 12, 2018

13 of 14 checks passed

ci/circleci: electron-osx-x64 Your tests failed on CircleCI
Details
Semantic Pull Request good to go
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details

@zcbenz zcbenz deleted the fix-remote-3-0-x branch Jul 12, 2018

@ckerr ckerr added this to Fixed for next release in 3.0.x Jul 12, 2018

@ckerr ckerr moved this from Fixed for next release to Fixed (3.0.0-beta.4) in 3.0.x Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.