Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable spell checking, which broke in upgrade to ch66 (backport: 3-0-x) #13650

Merged
merged 1 commit into from Jul 12, 2018

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

trop bot commented Jul 12, 2018

Backport of #13616

See that PR for details.

fix: enable spell checking, which broke in upgrade to ch66
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.

Added the first (!) test for spellchecking, too.

Fixes #13608.

[1]: https://chromium.googlesource.com/chromium/src/+/03563dd1635a028d286beaf8b4f3d637cc4a8830

@trop trop bot requested a review from as a code owner Jul 12, 2018

@trop trop bot referenced this pull request Jul 12, 2018

Merged

fix: enable spell checking, which broke in upgrade to ch66 #13616

3 of 4 tasks complete

@trop trop bot added the backport label Jul 12, 2018

@ckerr

ckerr approved these changes Jul 12, 2018

@nornagon nornagon merged commit 041c952 into electron:3-0-x Jul 12, 2018

11 of 12 checks passed

ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
Semantic Pull Request good to go
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.