Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Don't run tests on GitHub release #13701

Merged
merged 1 commit into from Jul 17, 2018

Conversation

Projects
None yet
2 participants
@jkleinsc
Copy link
Contributor

jkleinsc commented Jul 17, 2018

Backport of #13662 for 3-0-x
Most importantly this contains the following change for the release process:
Changes make sure tests don't run when building for GitHub releases. Tests should run for nightly builds, but not when we are releasing an official release.

This PR also includes the following changes for nightly builds:

  1. Make sure artifacts for nightly release builds are properly saved on each CI platform. This change allows the release artifacts to be downloaded directly from the CI build pages.
  2. Fix for VSTS slack integration -- build results were not being posted to Slack.
Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • commit messages or PR title follow semantic commit guidelines
make sure tests don't run for GitHub releases.
Also fix VSTS slack integration and
Update to latest libchromiumcontent

(cherry picked from commit 1c70a1c)

@jkleinsc jkleinsc requested a review from ckerr Jul 17, 2018

@jkleinsc jkleinsc requested a review from as a code owner Jul 17, 2018

@ckerr

ckerr approved these changes Jul 17, 2018

@ckerr ckerr merged commit 9237d46 into 3-0-x Jul 17, 2018

11 of 14 checks passed

appveyor: electron-x64-pr Waiting for AppVeyor build to complete
Details
ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
Semantic Pull Request good to go
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details

@jkleinsc jkleinsc deleted the no-tests-on-github-release branch Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.